Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Minted and TokensBurned events #1305

Merged
merged 3 commits into from
Sep 7, 2018
Merged

Remove Minted and TokensBurned events #1305

merged 3 commits into from
Sep 7, 2018

Conversation

come-maiz
Copy link
Contributor

No description provided.

frangio
frangio approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frangio frangio merged commit fa49e51 into OpenZeppelin:master Sep 7, 2018
@frangio frangio added this to the v2.0 milestone Sep 7, 2018
@come-maiz come-maiz deleted the no-mint-no-burn-events branch September 7, 2018 16:34
@yosriady
Copy link

What was the rationale behind removing these events?

@frangio
Copy link
Contributor

frangio commented Sep 11, 2018

@yosriady They were redundant, because the information is already conveyed in Transfer events as is suggested in the ERC20 document. That is, a minting operation is logged as Transfer(0, to, amount), and the reverse for a burn. Additionally the from argument is indexed so it's efficient to filter only the minting events.

@frangio frangio mentioned this pull request Oct 2, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@come-maiz @yosriady @frangio