Improve encapsulation on BreakInvariantBounty #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-maiz
added
kind:improvement
contracts
frangio
force-pushed
the
refactor/1174/private-state-vars-bounty
branch
from
b5f5991 to
780125b
Compare
|
I rebased on |
come-maiz
commented
Sep 4, 2018
| * @dev Determine if the bounty was claimed. | ||
| * @return true if the bounty was claimed, false otherwise. | ||
| */ | ||
| function wasClaimed() public view returns(bool) { |
There was a problem hiding this comment.
@frangio what should I do here? Rename the function to claimed or rename the variable to wasClaimed?
There was a problem hiding this comment.
I like claimed. I'm not sure about wasClaimed because in English the correct thing would be "has been claimed".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1174.
Requires #1253.
npm run lint:all:fix).