-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Babel #1074
Remove Babel #1074
Conversation
do we use jshint at all, actually? I don't think we do, so we can delete .jshintrc |
LGTM after rebase @nventuro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the package-lock needs to be updated. Otherwise LGTM.
import { ethGetBalance, ethSendTransaction } from './helpers/web3'; | ||
const { ethGetBalance, ethSendTransaction } = require('./helpers/web3'); | ||
|
||
var SecureTargetBounty = artifacts.require('SecureTargetBounty'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use const
for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we're only removing Babel in this PR, that's coming on a separate one to keep everything tidy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #1091.
} | ||
} | ||
} | ||
}, | ||
"babel-preset-env": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should've probably been removed, right? Re-run npm install
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into that as well, but they're dev dependencies of solidity-coverage, so they're in our package-lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it. 🙂
that would be nice, since I'm not a Node.js / web expert and currently scratching my head on trying to use the helper scripts for test but |
We no longer use
import
🎉Fixes #1062