Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Francisco <[email protected]>
  • Loading branch information
Amxx and frangio authored Jun 23, 2023
1 parent 812ecb4 commit 802d4d8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion contracts/governance/IGovernor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ abstract contract IGovernor is IERC165, IERC6372 {
*
* NOTE: This value is stored when the proposal is submitted so that possible changes to the value do not affect
* proposals that have already been submitted. The type used to save it is a uint32. Consequently, while this
* interface returns a uint256, the value it returns should fit in a uint48.
* interface returns a uint256, the value it returns should fit in a uint32.
*/
function votingPeriod() public view virtual returns (uint256);

Expand Down
2 changes: 1 addition & 1 deletion contracts/governance/extensions/GovernorSettings.sol
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import "../Governor.sol";
abstract contract GovernorSettings is Governor {
// amount of token
uint256 private _proposalThreshold;
// duration: limited to uint48 in core (same as clock() type)
// timepoint: limited to uint48 in core (same as clock() type)
uint48 private _votingDelay;
// duration: limited to uint32 in core
uint32 private _votingPeriod;
Expand Down

0 comments on commit 802d4d8

Please sign in to comment.