This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Support starknet token for mainnet deployments #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐋🐋🐋🐋🐋🐋 |
There was a problem hiding this comment.
Looks great, @ericnordelo! I left a few suggestions (basically just one thing)
Co-authored-by: Andrew Fleming <[email protected]>
Co-authored-by: Andrew Fleming <[email protected]>
Co-authored-by: Andrew Fleming <[email protected]>
andrew-fleming
previously approved these changes
Oct 31, 2022
martriay
previously approved these changes
Nov 2, 2022
tests/test_common.py
Outdated
Comment on lines
17
to
26
| @pytest.mark.only | ||
| @pytest.mark.parametrize( | ||
| "operation, signature, max_fee, query_flag, mainnet_token", | ||
| [ | ||
| ("invoke", None, 0, "simulate", None), | ||
| ("call", None, None, None, None), | ||
| ("deploy", None, 5, None, "token"), | ||
| ("declare", None, 3, "estimate_fee", "token2"), | ||
| ], | ||
| ) |
There was a problem hiding this comment.
have you considered doing all permutations? or is it too slow?
Suggested change
| @pytest.mark.only | |
| @pytest.mark.parametrize( | |
| "operation, signature, max_fee, query_flag, mainnet_token", | |
| [ | |
| ("invoke", None, 0, "simulate", None), | |
| ("call", None, None, None, None), | |
| ("deploy", None, 5, None, "token"), | |
| ("declare", None, 3, "estimate_fee", "token2"), | |
| ], | |
| ) | |
| @pytest.mark.parametrize('operation', ['invoke', 'call', 'deploy', 'declare']) | |
| @pytest.mark.parametrize('signature', [None]) | |
| ... |
There was a problem hiding this comment.
I think that's a great idea! If I add this, it won't be too slow, but I'm not sure what will happen if we adopt this for all the tests. If this makes the test suite too slow in the future, we can refactor this then, I guess. I will add it.
…lo/nile into feat/support-token-option-#239
…-token-option-#239
ericnordelo
dismissed stale reviews from martriay and andrew-fleming
via
92afae4
ericnordelo
requested review from
martriay and
andrew-fleming
and removed request for
andrew-fleming
andrew-fleming
approved these changes
Nov 3, 2022
martriay
approved these changes
Nov 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.