Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove token dual dispatchers #1175

feat: apply review suggestions

03ecad0
Select commit
Loading
Failed to load commit list.
Merged

Remove token dual dispatchers #1175

feat: apply review suggestions
03ecad0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project/coverage succeeded Oct 3, 2024 in 1s

91.51% (+2.63%) compared to 8ef6a41

View this Pull Request on Codecov

91.51% (+2.63%) compared to 8ef6a41

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (8ef6a41) to head (03ecad0).
Report is 3 commits behind head on remove-dual-dispatchers.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           remove-dual-dispatchers    #1175      +/-   ##
===========================================================
+ Coverage                    88.87%   91.51%   +2.63%     
===========================================================
  Files                           57       46      -11     
  Lines                         1375     1178     -197     
===========================================================
- Hits                          1222     1078     -144     
+ Misses                         153      100      -53     
Files with missing lines Coverage Δ
packages/token/src/erc1155/erc1155.cairo 98.96% <100.00%> (ø)
packages/token/src/erc721/erc721.cairo 90.24% <100.00%> (-0.82%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6a41...03ecad0. Read the comment docs.