Fix warnings #240
Merged
Fix warnings #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will wait a few days for @brozef to respond. If not we will merge. |
|
I am merging, if we need to revert we can. |
donavanbecker
merged commit 156831a
into
OpenWonderLabs:beta-2.1.0
3 of 5 checks passed
|
Build failed @dnicolson |
|
Those are just TypeScript warnings, I will override the type definition until Noble 1.9.2-25 is released. |
|
looks good thanks @dnicolson |
donavanbecker
added a commit
that referenced
this pull request
May 14, 2024
## [2.1.0](https://github.com/OpenWonderLabs/node-switchbot/releases/tag/v2.1.0) (2024-05-14) ### What's Changed - Add Full Switchbot Lock Support [#232](#232), Thanks [@brozef](https://github.com/brozef) - Fix TypeScript issues & warnings [#239](#239) [#240](#240) [#241](#241), Thanks [@dnicolson](https://github.com/dnicolson) - Update Noble [#242](#242), Thanks [@dnicolson](https://github.com/dnicolson) dnicolson - Housekeeping and update dependencies **Full Changelog**: v2.0.3...v2.1.0
Merged
donavanbecker
added a commit
that referenced
this pull request
May 14, 2024
## [2.1.0](https://github.com/OpenWonderLabs/node-switchbot/releases/tag/v2.1.0) (2024-05-14) ### What's Changed - Add Full Switchbot Lock Support [#232](#232), Thanks [@brozef](https://github.com/brozef) - Fix TypeScript issues & warnings [#239](#239) [#240](#240) [#241](#241), Thanks [@dnicolson](https://github.com/dnicolson) - Update Noble [#242](#242), Thanks [@dnicolson](https://github.com/dnicolson) dnicolson - Housekeeping and update dependencies **Full Changelog**: v2.0.3...v2.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Some optional chaining operators were introduced after others being removed in #232.
💡 Proposed solution
Remove them and fix new warnings.
@brozef I assume you removed the optional chaining operators for Node.js 12 compatibility but are passing the
nobleinstance, as the dynamic import is only supported in Node.js 14.