allowPush support for IR Devices #529 (with namespace fix) #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option `allowPush`, this will allow commands to be sent even if device state is already in state that is being pushed.
Added `allowPush` property and logic, to allow commands to be sent even if a device is already in the state to be pushed.
Added `allowPush` property and logic, to allow commands to be sent even if a device is already in the state to be pushed. Additionally, added a check to `pushFanOffChanges()` to not push by default if the fan is already in an `Off` state, to make it consistent with `pushFanOffChanges()`
Added `allowPush` property and logic, to allow commands to be sent even if a device is already in the state to be pushed.
Added `allowPush` property and logic, to allow commands to be sent even if a device is already in the state to be pushed.
Added `allowPush` property and logic, to allow commands to be sent even if a device is already in the state to be pushed.
Added `allowPush` property and logic, to allow commands to be sent even if a device is already in the state to be pushed.
Added `allowPush` property and logic, to allow commands to be sent even if a device is already in the state to be pushed. Additionally, added a check to `pushTvOffChanges()` to not push by default if the TV is already in an `Off` state, to make it consistent with `pushTvOnChanges()`
Added `allowPush` property and logic, to allow commands to be sent even if a device is already in the state to be pushed.
Added `allowPush` property and logic, to allow commands to be sent even if a device is already in the state to be pushed.
`pushFanOnChanges` was named `pushFanOffChanges`, causing a namespace conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Currently, IR Devices do not send signals if their target devices are already in the desired state from Homebridge's perspective.
💡 Proposed solution
IR Devices, apart from Air Conditioners which have their own complex governing logic for transmission, now support sending IR commands even if the target device is already in the desired state from Homebridge's perspective.
⚙️ Release Notes
(Dependent on UI implementation / documentation to allow users set the allowPush property appropriately)
Added
allowPushproperty and logic, to allow IR commands to be sent even if a device is already in the state to be pushed.This is a follow-up to issue #310