Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Playback, Volume Control, and User Interface Adjustments. #386

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

generalfreed
Copy link
Contributor

@MakinoharaShoko
OpenWebGAL/WebGAL_Terre#170

Audio Volume Reference: The audio volume for videos now references the volume set for the BGM.
Menu Visibility during Playback: The menu is now hidden while a video is playing.
Non-Skippable by Single Click: Previously, a single click would skip the video. This behavior has been changed.
Skip via Double Click: If users wish to skip the video, they can do so by double-clicking.

@MakinoharaShoko
Copy link
Member

I have received your pr and will review in a few days.

@MakinoharaShoko
Copy link
Member

I believe that it is possible to use a parameter to control whether skipping the video is allowed

@generalfreed
Copy link
Contributor Author

generalfreed commented Oct 14, 2023

I believe that it is possible to use a parameter to control whether skipping the video is allowed

Excuse me, what exactly do you mean by this?

When playing a video, I plan to use the skip function to prevent it from being skipped.

@MakinoharaShoko
Copy link
Member

Use a parameter in the statement to control whether skipping the video is allowed. If skipping is allowed, keep the original logic. If skipping is not allowed, set blockingNext to true to block the step. Changing the skip from a single click to a double click doesn't seem to make much of a difference.

@generalfreed
Copy link
Contributor Author

Sorry for the late response.
Fixed.

@MakinoharaShoko
Copy link
Member

Some repairs have been made, please check if they meet your functional expectations

@generalfreed
Copy link
Contributor Author

Confirmed.
Thank you for the correction.

@MakinoharaShoko MakinoharaShoko merged commit a34b636 into OpenWebGAL:dev Oct 22, 2023
1 check passed
MakinoharaShoko added a commit to ClodLingxi/WebGAL that referenced this pull request Dec 20, 2024
Video Playback, Volume Control, and User Interface Adjustments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants