Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: this time fix compat for realz #310

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: this time fix compat for realz #310

merged 1 commit into from
Nov 21, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Nov 21, 2024

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced logging for deprecation warnings related to message imports.
  • Refactor

    • Improved clarity in handling deprecation warnings.
  • Documentation

    • Updated deprecation warning message to guide users towards importing from ovos-bus-client.

Copy link
Contributor

coderabbitai bot commented Nov 21, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the ovos_utils/fakebus.py file by restoring the import statement for EventEmitter from the pyee library. It updates the __new__ method in the Message class to log deprecation warnings with a clearer message, advising users to import from ovos-bus-client instead of using FakeMessage. The error handling in the FakeBus class remains unchanged, ensuring that overall functionality is consistent even if certain imports are unavailable.

Changes

File Change Summary
ovos_utils/fakebus.py - Restored import statement for EventEmitter from pyee.
- Updated __new__ method in Message to log structured deprecation warnings.

Poem

🐰 In the code where bunnies hop,
Changes made, we won't stop!
With clearer paths and warnings bright,
Our FakeMessage takes to flight.
A little tweak, a gentle cheer,
In the land of code, we persevere! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the fix label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.82%. Comparing base (32b9fe1) to head (6407d97).
Report is 20 commits behind head on dev.

Files with missing lines Patch % Lines
ovos_utils/fakebus.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #310      +/-   ##
==========================================
+ Coverage   44.74%   44.82%   +0.07%     
==========================================
  Files          33       33              
  Lines        3426     3418       -8     
==========================================
- Hits         1533     1532       -1     
+ Misses       1893     1886       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@JarbasAl JarbasAl merged commit 28a7fe7 into dev Nov 21, 2024
10 checks passed
@JarbasAl JarbasAl deleted the JarbasAl-patch-1 branch November 21, 2024 19:33
@github-actions github-actions bot added fix and removed fix labels Nov 21, 2024
@github-actions github-actions bot added fix and removed fix labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant