fix MycroftAI/lingua-franca/issues/224 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_extract_date_years(self): | ||
| date = datetime(2017, 6, 27, tzinfo=default_timezone()) # Tue June 27, 2017 | ||
| self.assertEqual(extract_datetime('in 2007', date)[0], | ||
| datetime(2007, 6, 27, tzinfo=date.tzinfo)) |
There was a problem hiding this comment.
I think we should bring this up with users, because there's definitely no correct answer, but this seems jarring to me
There was a problem hiding this comment.
it makes sense if you think deeper about the meaning of anchorDate, but at first it is very jarring at first indeed
regardless im calling this out of scope, this is a quick bugfix only. Keep in mind the full rewrite is still happening so this is a stop gap and i don't want to devote a lot of time to it
There was a problem hiding this comment.
Yeah it seems like we really want a "granularity" indicator here too - but this is better than what exists.
1 task
krisgesling
added a commit
to MycroftAI/lingua-franca
that referenced
this pull request
Apr 19, 2022
Fixes #224 - extract_datetime parsing of phrases like "in 2007" Whilst this isn't ideal behaviour, it is better than returning a time. This is a port of OpenVoiceOS#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8