-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/langcode_utils #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would maintaining tuples that are parsed into dicts at language load be easier to maintain? Just thinking about maintaining 2x dicts for each language
I've been out for hours, and we all arrived so very simultaneously the timestamps made me think something was wrong with my clock. I love it, but I agree with Daniel that the collections should be assembled from common data rather than maintaining two. The functions could return from that. I'd wanna think about it, but I don't think it would need to be localized at that point, either. |
I think the names should remain localized ( |
Indeed. I meant as in the localized function wrapper. There probably doesn't need to be a distinct function in the Spanish parsers if the top level function can return the entry from common data and the lang code. |
should i just move it to a .json resource file like is being done for other utils like the normalizer? that was the direction lingua franca was going, makes it easy to support new langs by sharing code and treating things as data when algorithms can be shared. our architecture allows easy subclassing to account for edge cases as is done with the normalizer |
json or yaml resources I think make sense for easier updates in general (this really is data, not code) |
1451a2e
to
ea518ce
Compare
Codecov Report
@@ Coverage Diff @@
## dev #5 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 62
Lines ? 15439
Branches ? 0
=====================================
Hits ? 0
Misses ? 15439
Partials ? 0 Continue to review full report at Codecov.
|
more tests dialect support langs.json resource file
520cdb5
to
9b211c8
Compare
adds 2 new utilities
pronounce_lang
andextract_langcode