Improve shuffling algorithm of connection list

[Hurukawa2121]

I propose implementing the Fisher-Yates shuffle algorithm to improve the shuffling of the connection target list.

Issue:

In the current shuffle algorithm, each element l->array[i] is swapped with a random element at index j in the entire array.
However, this method does not produce all permutations uniformly, resulting in a bias where some permutations occur more frequently than others.

Solution:

To ensure all permutations are generated with equal probability, I suggest using the Fisher-Yates shuffle algorithm.

Thank you for your contribution

You are welcome to open PR, but they are used for discussion only. All
patches must eventually go to the openvpn-devel mailing list for review:

• https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Please send your patch using git-send-email. For example to send your latest commit to the list:

$ git send-email [email protected] HEAD~1

For details, see these Wiki articles:

• https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
• https://community.openvpn.net/openvpn/wiki/Contributing

[cron2]

This looks interesting.

To progress, please add some comments to the new code explaining what this does ("Shuffle with Fisher-Yates algorithm which has less bias to ...."). Otherwise this creates just code that is not meaningful to the next person looking at it.

Then, send the patch to the openvpn-devel list, or to our gerrit. We do not merge patches from GH.

thanks ;-)