Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do some console ops for visual tracking in authentication routine #820

Merged
merged 1 commit into from
Nov 11, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented Nov 11, 2015

  • Also trying out chalk dep to see if the VPS pro logs can handle this without too much visual interference... nicer in development and debug modes... if not will remove.

Applies to Code Migrations, #430, and jaredhanson/passport#400 (comment)

Still getting username is taken with passport@0.3.2 and passport-github@1.0.0
but not passport@0.2.2 with passport-github@0.1.5

* Also trying out *chalk* dep to see if the VPS pro logs can handle this without too much visual interference... nicer in development and debug modes... if not will remove.

Applies to Code Migrations, OpenUserJS#430,  and jaredhanson/passport#400 (comment)

Still getting `username is taken` with *passport*@0.3.2 and *passport-github*@1.0.0
but **not** *passport*@0.2.2 with *passport-github*@0.1.5
@Martii Martii added bug You've guessed it... this means a bug is reported. migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Nov 11, 2015
Martii added a commit that referenced this pull request Nov 11, 2015
Do some console ops for visual tracking in authentication routine

Auto-merge
@Martii Martii merged commit b9375c0 into OpenUserJS:master Nov 11, 2015
@Martii
Copy link
Member Author

Martii commented Nov 11, 2015

chalk dep okay in logs... appears the escape codes are stripped out in VPS logs.

@Martii Martii deleted the consoleMsgForPossibleAuthFail branch November 11, 2015 12:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Development

Successfully merging this pull request may close these issues.

1 participant