Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing protocol for *fakeS3* which is needed for *node* v0.12.x #629

Merged
merged 1 commit into from
May 1, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented May 1, 2015

  • Removes the previous exception found with fakeS3 and all importing/creation of scripts.
  • Bump ./package.json to reflect tested nodejs major versions... do not use 0.12.0 on nodejitsu due to previous deploy failures during 0.10.33 static testing

NOTE: Regression tested on 0.10.xx and appears okay... retested on local pro. There are some deprecation warnings that may not be able to be addressed until node host is upgraded in #425

Applies to #581

* Removes the previous exception found with *fakeS3* and all importing/creation of scripts.
* Bump `./package.json` to reflect tested nodejs major versions... **do not use 0.12.0 on nodejitsu due to previous deploy failures during 0.10.33 static testing

**NOTE** Regression tested on 0.10.xx and appears okay... retested on local pro. There are some deprecation warnings that may not be able to be addressed until node host is upgraded in OpenUserJS#425

Applies to OpenUserJS#581
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels May 1, 2015
Martii added a commit that referenced this pull request May 1, 2015
Fix missing protocol for *fakeS3* which is needed for *node* v0.12.x

Auto-merge
@Martii Martii merged commit eba4cab into OpenUserJS:master May 1, 2015
@Martii Martii deleted the Issue-581fixProtocolForFakeS3 branch May 1, 2015 00:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Development

Successfully merging this pull request may close these issues.

1 participant