Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 97 #607

Closed
wants to merge 5 commits into from
Closed

Issue 97 #607

wants to merge 5 commits into from

Conversation

Dost60m
Copy link

@Dost60m Dost60m commented Mar 27, 2015

No description provided.

@Martii
Copy link
Member

Martii commented Mar 27, 2015

We appreciate the effort however a build/exec/deploy system is assigned in #249 and we have also currently decided not to use linters/hinters at the moment due to historical incompatibilities although sometimes they can point out some STYLEGUIDE.md conformance issues. Also #425 is being tracked in higher priority at the moment.

Most importantly the CONTRIBUTING.md doesn't appear to have been followed. Please review these links before submitting a pull request on something that has already been discussed. Not to mention #97 is already currently closed. Thanks though. :)


One other note... decided to validate one of the commits against current /libs/flags.js and at least one file line change doesn't match up to current source file line.

@Martii Martii closed this Mar 27, 2015
@Martii Martii added duplicate This means already been reported. Always reference in a comment what issue or pull request number… invalid Try, try again. needs mitigation Needs additional followup. labels Mar 27, 2015
@Martii Martii removed the needs mitigation Needs additional followup. label Aug 9, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This means already been reported. Always reference in a comment what issue or pull request number… invalid Try, try again.
Development

Successfully merging this pull request may close these issues.

3 participants