Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some GFM being ignored in about pages #290

Closed
Martii opened this issue Aug 15, 2014 · 0 comments · Fixed by #305
Closed

Some GFM being ignored in about pages #290

Martii opened this issue Aug 15, 2014 · 0 comments · Fixed by #305
Labels
bug You've guessed it... this means a bug is reported.

Comments

@Martii
Copy link
Member

Martii commented Aug 15, 2014

Rest of plain md works but for some reason part of the options for marked aren't being read.

Don't have a clue why either... yet.

Specifically tables aren't being transformed from GFM to markup. (Code fencing appears to work okay)

I've tried a bunch of things so far:

  • Reinitialized local node_modules folder (e.g. deleted it and redid $npm install) and that fixed it in issues comments and previews in discussions and other previews from the toolbar.
  • Moving scope of renderMd into callback... result no change
  • Looked for identifier naming conflicts e.g. changed a few names that might conflict usually in client side JavaScript... result no change
  • Moved a new marked package reference into the document.js controller and confirmed that it is setting flags, specifically with it's native sanitize value... does sanitize... but no go with parsing GFM tables to markup. :\
  • Double checked sanitization json to ensure tables are fully allowed... but they should be because they work in script about pages already.... result no change.
  • Disabled sanitizing to rule out that package... result no change
  • Tested in non-strict... result no change
@Martii Martii added the bug label Aug 15, 2014
@Martii Martii mentioned this issue Aug 15, 2014
Closed
@Martii Martii changed the title GFM being ignored in about pages Some GFM being ignored in about pages Aug 18, 2014
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 18, 2014
Normalize the document mcv for about pages
1c69147 
* Rearrange footer and expand for bootstrap
* Rename DMCA/TOS/PP to full name using GH wiki style naming
* Add an /about/about landing page for the Index/TOC
* Breadcrumbs for about pages
* Use more bootstrap classes
* Fix CSS to be `document-content` instead of `user-content`
* Using GH wiki as image CDN for now
* Rearrange the controller a little

Known issue:
* OpenUserJS#290
@Martii Martii mentioned this issue Aug 18, 2014
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 20, 2014
Some more fixes for about pages
057408f 
* Fix table displaying. Closes OpenUserJS#290
* Some prettying up
* Speed up node a bit by using lowercase utf8... this isn't standard as we've seen before but the actual buffer library loops through the lowercase tests first then checks for lowercase and repeats.
* Some standardization with our STYLEGUIDE
@Martii Martii mentioned this issue Aug 20, 2014
Merged
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some more fixes for about pages Martii/OpenUserJS.org
1 participant
@Martii