Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestra): missing node_selector in helm test template #164

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

fbuchmeier-abi
Copy link
Contributor

This fixes: #163

Successful helm template & kubectl validate:

kubectl validate <(helm template test ./orchestra --set services.node_selectors.'kubernetes\.io/arch'=amd64 --show-only templates/tests/precheck.yaml )
coalesce.go:289: warning: destination for orchestra.services.node_selectors is a table. Ignoring non-table value ([])

/proc/self/fd/11...OK

Helm template output:

---
# Source: orchestra/templates/tests/precheck.yaml
apiVersion: v1
kind: Pod
metadata:
  name: test-orchestra-test
  namespace: default
  annotations:
    "helm.sh/hook": pre-install,pre-upgrade
    "helm.sh/hook-weight": "-5"
    "helm.sh/hook-delete-policy": hook-succeeded,before-hook-creation
    sidecar.istio.io/inject: "false"
    argocd.argoproj.io/sync-wave: "20"
spec:
  restartPolicy: Never
  containers:
    - name: test-values
      image: ghcr.io/tremolosecurity/python3:1.0.0
      imagePullPolicy: Always
      command: ["python", "/scripts/check-hosts.py"]
      securityContext:
        allowPrivilegeEscalation: false
        capabilities:
          drop:
          - "ALL"
        
        seccompProfile:
          type: RuntimeDefault
        runAsNonRoot: true
        runAsUser: 431
        runAsGroup: 433
        
      volumeMounts:
      - name: scripts
        mountPath: "/scripts"
        readOnly: true
      - name: tmp-pad
        mountPath: "/tmp-pad"
  
  securityContext:
    fsGroup: 433
    supplementalGroups: [433]
    seccompProfile:
      type: RuntimeDefault
    runAsNonRoot: true
    runAsUser: 431
    runAsGroup: 433
  
  
  
  nodeSelector: 
    kubernetes.io/arch: "amd64"
  
  
  
  volumes:
    - name: scripts
      configMap:
        name: check-hosts-test
    - name: tmp-pad
      emptyDir: {}

fbuchmeier-abi and others added 10 commits May 7, 2024 11:34
…kustomize as helm post-renderer

Merge in OSSC/openunison-helm-charts from fix/152-duplicate-securityContext to master

* commit '8eb33939288bdd3533e34a93d7ddce88deada326':
  fix: duplicate securityContext fails with kustomize as helm post-renderer
…lm test

Merge in OSSC/openunison-helm-charts from fix/163-missing-node-selector to master

* commit '138630f0cf45773e00b2d450d9d397e97ff89334':
  fix: missing node selector in orchestra helm test
@fbuchmeier-abi
Copy link
Contributor Author

I just saw that my changes from #153 are also in this PR. @mlbiam if you could look at this first and 164 later this would save me some trouble in regards to our Open Source Contribution process :)

@mlbiam mlbiam merged commit 9be5826 into OpenUnison:master Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[orchestra] Missing node selector in test job
2 participants