Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer: added support for mob attribute list #51

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

timlehr
Copy link
Collaborator

@timlehr timlehr commented Jul 20, 2024

Requires #49

Summarize your change.

The current adapter doesn't allow setting of mob attributes. This change allows for setting those attributes, therefore also enabling round-tripping of the attributes translated by the AAF reader.

Tests added

- test_aaf_adapter.py

@timlehr timlehr marked this pull request as ready for review September 27, 2024 22:12
@timlehr timlehr force-pushed the mobAttributeList_tlehr branch 2 times, most recently from 9d38df4 to 8dc4a28 Compare October 8, 2024 20:17
Copy link
Member

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Roger Sacilotto

@meshula meshula merged commit 61a77c5 into OpenTimelineIO:main Oct 15, 2024
36 checks passed
@timlehr timlehr deleted the mobAttributeList_tlehr branch October 15, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants