Prevent duplicate issues on GitHub reports #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent duplicate GitHub issues by stopping on getIssue failures
Ndpnt
force-pushed
the
avoid-duplicate-issues-on-git-hub-reports
branch
from
337b6a2 to
aa3b7f5
Compare
Nock versions < 14 cannot mock native `fetch` requests used by Octokit > 2.0.2. However, Nock 14.0.0-beta.15 can handle these requests. This serves as a temporary fix until Nock v14 is officially released.
Ndpnt
force-pushed
the
avoid-duplicate-issues-on-git-hub-reports
branch
from
88b6ab4 to
88d3771
Compare
MattiSG
approved these changes
Oct 22, 2024
src/reporter/github.js
Outdated
| } | ||
| } catch (error) { | ||
| logger.error(`🤖 Failed to handle repository labels: ${error.message}`); |
There was a problem hiding this comment.
What is the point of this “robot” emoji in the logs?
src/reporter/github.js
Outdated
|
|
||
| return this.closeIssue(openedIssue); | ||
| return logger.info(`🤖 Closed issue #${openedIssue.number}: ${openedIssue.html_url}`); |
There was a problem hiding this comment.
I find it useful to log the changes made to the reported issues.
src/reporter/github.js
Outdated
| return this.closeIssue(openedIssue); | ||
| return logger.info(`🤖 Closed issue #${openedIssue.number}: ${openedIssue.html_url}`); | ||
| } catch (error) { | ||
| logger.error(`🤖 Failed to handle issue "${title}": ${error.message}`); |
There was a problem hiding this comment.
Suggested change
| logger.error(`🤖 Failed to handle issue "${title}": ${error.message}`); | |
| logger.error(`Failed to update issue "${title}": ${error.message}`); |
src/reporter/github.js
Outdated
| const [managedLabel] = issue.labels.filter(label => managedLabelsNames.includes(label.name)); // it is assumed that only one specific reason for failure is possible at a time, making managed labels mutually exclusive | ||
| if (issue.state == GitHub.ISSUE_STATE_CLOSED) { | ||
| await this.openIssue(issue); | ||
| logger.info(`🤖 Reopen issue #${issue.number}: ${issue.html_url}`); |
There was a problem hiding this comment.
Do we really need to log this?
Suggested change
| logger.info(`🤖 Reopen issue #${issue.number}: ${issue.html_url}`); | |
| logger.info(`Reopened issue #${issue.number}: ${issue.html_url}`); |
src/reporter/github.js
Outdated
| await this.addCommentToIssue({ issue, comment: description }); | ||
| logger.info(`🤖 Updated issue #${issue.number}: ${issue.html_url}`); | ||
| } catch (error) { | ||
| logger.error(`🤖 Failed to handle issue "${title}": ${error.message}`); |
There was a problem hiding this comment.
Suggested change
| logger.error(`🤖 Failed to handle issue "${title}": ${error.message}`); | |
| logger.error(`Failed to update issue "${title}": ${error.message}`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.