Lint commit messages to enforce consistency #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiSG
requested changes
Mar 7, 2024
|
04d5f54 seems to be a test commit 😉 |
MattiSG
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Looking forward to trying that out! As discussed synchronously, this might be useful or just as likely very frustrating for contributors. I am curious to see if this proves useful or if we remove it 😊 Thank you for suggesting that experiment! I already like that we could update our rules to reflect reality 👍
|
@Ndpnt do you need anything from me here? |
No, it's ok now, thanks! |
Co-authored-by: Matti Schneider <[email protected]>
Ndpnt
force-pushed
the
add-commit-linter
branch
from
1235057 to
82dff76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example result can be seen here: https://github.com/Ndpnt/engine/actions/runs/8186516043/job/22385045460