Fix validation for removed terms types

#1020
OpenTermsArchive · Sep 6, 2023 · 91b4b55 · 91b4b55
2 parents 60a2343 + 665db13
commit 91b4b55
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,11 @@
 
 All changes that impact users of this module are documented in this file, in the [Common Changelog](https://common-changelog.org) format with some additional specifications defined in the CONTRIBUTING file. This codebase adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## Unreleased
+## Unreleased [patch]
+
+### Fixed
+
+- Fix validation for removed terms types
 
 ## 0.30.0 - 2023-07-10
 

diff --git a/scripts/declarations/validate/index.mocha.js b/scripts/declarations/validate/index.mocha.js
@@ -78,6 +78,10 @@ export default async options => {
         if (!schemaOnly && service) {
           service.getTermsTypes()
             .filter(termsType => {
+              if (!service.terms[termsType]?.latest) { // If this terms type has been deleted and there is only a historical record for it, but no current valid declaration
+                return false;
+              }
+
               if (servicesTermsTypes[serviceId] && servicesTermsTypes[serviceId].length > 0) {
                 return servicesTermsTypes[serviceId].includes(termsType);
               }