Add option for specifying HTTP endpoint URL path #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "details" query portion would always be present in logged URL regardless of whether it would actually be used. Tidy up the URL generation a little bit to make it easier to keep consistent.
The option can be useful for cases where you need multiple tcollector instances to report to different URLs to be able to differentiate between them without having to add redundant data (via e.g. the "tag" option for tcollector). In our use case we're proxying the requests to different TSD instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on PR #358 (the first two commits). They're included here for completeness.
Comment copied from commit message which explains the rationale:
The option can be useful for cases where you need multiple tcollector
instances to report to different URLs to be able to differentiate between
them without having to add redundant data (via e.g. the "tag" option for
tcollector). In our use case we're proxying the requests to different TSD
instances.