Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Flatbox Revision 4 support #95

Merged

Conversation

fluxcorenz
Copy link

Restore support for Flatbox Revision 4.

Tested on my own Flatbox Rev4 devices.

Default button mapping mimics Bentobox.

Copy link

@TheTrainGoes TheTrainGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the extra set of defines needed on this? Have you tested with just assigning the pin directly?

@fluxcorenz
Copy link
Author

Absolutely it will work without. It's just much easier to determine which button connects to which pin (and how it's mapped to the GP2040 functions) with the extra set. If define space is lacking (?) it could be converted to a set of comments describing the flatbox SW number to pin number, just means that a person manually fiddling with the gp2040 button mapping in code would have to do an extra set of manual lookups via the comments.

@TheTrainGoes
Copy link

No space issues that I am aware of that you would not have run into while testing so you should have a good runway there.

I will PM you with a few additional concerns on Discord.

@TheTrainGoes TheTrainGoes added the enhancement New feature or request label Sep 19, 2022
@hurik
Copy link

hurik commented Sep 20, 2022

No space issues that I am aware of that you would not have run into while testing so you should have a good runway there.

I will PM you with a few additional concerns on Discord.

What are the additional concerns?

It tested it on my Flatbox Rev4 and it is working fine!

Thanks you @fluxcorenz!

@TheTrainGoes
Copy link

Hey @hurik ,

The additional concerns were more about legacy support and ensuring we had done a good sample of tests before releasing it.

As we are seeing with the CC2.0 there are different versions and parts used on some of them which have lead to some compatibility issues.

I would like to ensure what we release has been tested as much as possible as not to leave people with a soft-bricked unit that might not know how to recover on their own.

@TheTrainGoes TheTrainGoes merged commit d427cb1 into OpenStickFoundation:main Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants