This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
Addon Rework - Per-Core Addons with Manager #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a stepping stone for getting add-ons enabled/disabled in the Web-UI config, and also should make it easier to manage add-ons from one location instead of two. This also takes away StorageManager's task of storing a public vector full of pointers, which we want to avoid.
Missed an end-line
…nse as each core should have its own add-ons in memory, rather than static (shared) memory. Also changed the ConfigManager slightly to remove the auto-update on neopico in config, as this was a hack. Also missed a runtime setting for gp2040aux.cpp to make it sleep a tiny bit.
|
Tested and working on my end. Good to merge if you are |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now add-ons are added per core with a manager, which allows add-ons to be added and memory recovered if an add-on is not used.