Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ahmedeldessouki #83

Merged
merged 13 commits into from
Feb 13, 2021
Merged

Ahmedeldessouki #83

merged 13 commits into from
Feb 13, 2021

Conversation

JacobMGEvans
Copy link
Member

No description provided.

AhmedEldessouki and others added 13 commits February 1, 2021 20:20
@AhmedEldessouki
test setup #74
4f8caad
@AhmedEldessouki
Tests
8572c31 
 removed The AllRaid assertions from App.test and moved them to AllRaids.test.
wrote ViewRaid Tests to cover all sorting the the Total view
@AhmedEldessouki
replaced most getByRole to getByText and getByAltText
5d8e8ad
@AhmedEldessouki
replaced most getByRole img to getByAltText
a6f6d52
@AhmedEldessouki @nobrayner
Update src/__tests__/App.test.tsx
0e310e9 
Co-authored-by: Braydon Hall <[email protected]>
@AhmedEldessouki
tests suggested changes
1a2b21c
@AhmedEldessouki
Feedback test
eaff0ec
@AhmedEldessouki
rules tests
76d16cf
@AhmedEldessouki
removed firebase/rules tests
430711c 
	estEnviroment node cause the snowpack build to fail
@JacobMGEvans
Merge branch 'main' into ahmedeldessouki
e4044ed
@nobrayner
Merge branch 'main' into ahmedeldessouki
45b13a3
@JacobMGEvans
Merge branch 'main' into ahmedeldessouki
c7afdc5
@JacobMGEvans
Tests broke with minor changes
4d86bc2 
- Removed some of those tests until they can be made more robust
- Removed some redundant testing behavior
- Iterations can be made on initial tests
@JacobMGEvans JacobMGEvans added Difficulty: Beginner 🤓 Good for newbie to start Raiding!! Items: Uncommon Type: Test Your Mettle 🧪 Can your code hold up to the brutal crucible of tests!? Type: Toolchain 🧰 Developer Experience related labels Feb 13, 2021
@JacobMGEvans
Copy link
Member Author

Replaces #75

@JacobMGEvans JacobMGEvans mentioned this pull request Feb 13, 2021
Closed
@JacobMGEvans JacobMGEvans merged commit 74a772d into main Feb 13, 2021
@JacobMGEvans JacobMGEvans deleted the ahmedeldessouki branch February 13, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobrayner nobrayner Awaiting requested review from nobrayner

Assignees
No one assigned
Labels
Difficulty: Beginner 🤓 Good for newbie to start Raiding!! Items: Uncommon Type: Test Your Mettle 🧪 Can your code hold up to the brutal crucible of tests!? Type: Toolchain 🧰 Developer Experience related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobMGEvans @AhmedEldessouki @nobrayner