Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning on gems dependencies #99

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

moustachu
Copy link
Member

@moustachu moustachu commented Jan 19, 2024

  • net-http :
/var/app/staging/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:68: warning: already initialized constant Net::ProtocRetryError
/opt/rubies/ruby-2.7.7/lib/ruby/2.7.0/net/protocol.rb:66: warning: previous definition of ProtocRetryError was here
/var/app/staging/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:214: warning: already initialized constant Net::BufferedIO::BUFSIZE
/opt/rubies/ruby-2.7.7/lib/ruby/2.7.0/net/protocol.rb:206: warning: previous definition of BUFSIZE was here
/var/app/staging/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:541: warning: already initialized constant Net::NetPrivate::Socket
/opt/rubies/ruby-2.7.7/lib/ruby/2.7.0/net/protocol.rb:503: warning: previous definition of Socket was here
  • harmonize source for decidim-module-ptp
Warning: The gem 'decidim-l10n' was found in multiple relevant sources.
  * https://github.com/OpenSourcePolitics/decidim-module-ptp.git (at feature/0.26/zip-code-voting@6148a81)
  * https://github.com/Pipeline-to-Power/decidim-module-ptp.git (at feature/0.26/zip-code-voting@79f07fe)
You should add this gem to the source block for the source you wish it to be installed from.
Warning: The gem 'decidim-ptp' was found in multiple relevant sources.
  * https://github.com/OpenSourcePolitics/decidim-module-ptp.git (at feature/0.26/zip-code-voting@6148a81)
  * https://github.com/Pipeline-to-Power/decidim-module-ptp.git (at feature/0.26/zip-code-voting@79f07fe)
You should add this gem to the source block for the source you wish it to be installed from.

@moustachu
Copy link
Member Author

@CodiumAI-Agent /describe

@CodiumAI-Agent
Copy link

Title

Fix Warnings Related to Gem Dependencies


User description

  • net-http :
/var/app/staging/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:68: warning: already initialized constant Net::ProtocRetryError
/opt/rubies/ruby-2.7.7/lib/ruby/2.7.0/net/protocol.rb:66: warning: previous definition of ProtocRetryError was here
/var/app/staging/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:214: warning: already initialized constant Net::BufferedIO::BUFSIZE
/opt/rubies/ruby-2.7.7/lib/ruby/2.7.0/net/protocol.rb:206: warning: previous definition of BUFSIZE was here
/var/app/staging/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.2.1/lib/net/protocol.rb:541: warning: already initialized constant Net::NetPrivate::Socket
/opt/rubies/ruby-2.7.7/lib/ruby/2.7.0/net/protocol.rb:503: warning: previous definition of Socket was here
  • harmonize source for decidim-module-ptp
Warning: The gem 'decidim-l10n' was found in multiple relevant sources.
  * https://github.com/OpenSourcePolitics/decidim-module-ptp.git (at feature/0.26/zip-code-voting@6148a81)
  * https://github.com/Pipeline-to-Power/decidim-module-ptp.git (at feature/0.26/zip-code-voting@79f07fe)
You should add this gem to the source block for the source you wish it to be installed from.
Warning: The gem 'decidim-ptp' was found in multiple relevant sources.
  * https://github.com/OpenSourcePolitics/decidim-module-ptp.git (at feature/0.26/zip-code-voting@6148a81)
  * https://github.com/Pipeline-to-Power/decidim-module-ptp.git (at feature/0.26/zip-code-voting@79f07fe)
You should add this gem to the source block for the source you wish it to be installed from.

Type

Bug fix


Description

This PR addresses warnings related to gem dependencies. The changes include:

  • The source for the decidim-smsauth and decidim-sms-twilio gems has been harmonized to OpenSourcePolitics/decidim-module-ptp to prevent the gems from being found in multiple sources.
  • The net-http gem has been added to the Gemfile to fix warnings related to constant reinitialization in the net-protocol gem.

Changes walkthrough

Relevant files                                                                                                                                 
Dependencies
Gemfile                                                                                                         
    Gemfile

    **The changes in the Gemfile include:

    • The source for the
      decidim-smsauth and decidim-sms-twilio gems has been
      changed from Pipeline-to-Power/decidim-module-ptp to
      OpenSourcePolitics/decidim-module-ptp.
    • The net-http
      gem has been added.**
+3/-2

✨ Usage guide:

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...
Enabling\disabling automation
  • When you first install the app, the default mode for the describe tool is:
pr_commands = ["/describe --pr_description.add_original_user_description=true" 
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

  • Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:
pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

  • type: the PR type.
  • summary: the PR summary.
  • walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels

The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].

If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

  • Main topic:performance - pr_agent:The main topic of this PR is performance
  • New endpoint - pr_agent:A new endpoint was added in this PR
  • SQL query - pr_agent:A new SQL query was added in this PR
  • Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
  • ...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

  • /review: Request a review of your Pull Request.
  • /describe: Update the PR title and description based on the contents of the PR.
  • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
  • /ask <QUESTION>: Ask a question about the PR.
  • /update_changelog: Update the changelog based on the PR's contents.
  • /add_docs 💎: Generate docstring for new components introduced in the PR.
  • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
  • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

@moustachu moustachu force-pushed the fix/gem-dependencies branch from 22dd4b3 to b5ee87e Compare January 19, 2024 13:59
@moustachu moustachu requested review from Quentinchampenois, a team and simonaszilinskas and removed request for a team and Quentinchampenois January 19, 2024 14:15
@Quentinchampenois Quentinchampenois merged commit 65753e5 into develop Jan 19, 2024
6 checks passed
@Quentinchampenois Quentinchampenois deleted the fix/gem-dependencies branch January 19, 2024 14:25
moustachu added a commit that referenced this pull request Jan 23, 2024
* feat: Add custom proposal states

* fix: Default filter params on proposals controller

* lint: Fix rubocop offenses

* fix: PP specs

* fix: Explore meetings system specs

* feat Bump Modules and add migrations

* Bump homepage proposals

* Update Gemfile.lock

* fix: downgrade net-imap

* fix: Add missing decidim-awesome migrations

* lint: Fix rubocop offenses

---------

Co-authored-by: Quentin Champenois <[email protected]>

* revert: Downgrade Decidim version (#95)

* Revert "feat Bump Modules and add migrations"

This reverts commit 8b406ee.

* fix: Bump homepage proposals and custom proposal states

* fix: Add db/schema.rb

* fix: Make the Half Signup TOS configurable with env var

* fix: Button budgets projects focus on click

* fix: Add Rails secret for half signup TOS

* fix: Remove Google translate bar when loaded

* fix: Change budgets_booth upstream branch

* fix: Bump module budgets booth

* fix: Update budgets booth revision

* fix: Fix button add vote in modal

* fix: warning on gems dependencies (#99)

* fix: warning on gems dependencies

* update bundler to 2.4.22

---------

Co-authored-by: quentinchampenois <[email protected]>
Co-authored-by: moustachu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants