Update the module with the fix #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentinchampenois
requested changes
Nov 24, 2023
Gemfile
Outdated
| @@ -16,7 +16,7 @@ gem "decidim-decidim_awesome" | |||
| gem "decidim-half_signup", git: "https://github.com/OpenSourcePolitics/decidim-module-half_sign_up", branch: DECIDIM_BRANCH | |||
| gem "decidim-homepage_interactive_map", git: "https://github.com/OpenSourcePolitics/decidim-module-homepage_interactive_map.git", branch: DECIDIM_BRANCH | |||
| # gem "decidim-homepage_proposals", git: "https://github.com/OpenSourcePolitics/decidim-module_homepage_proposals.git", branch: DECIDIM_BRANCH | |||
| gem "decidim-homepage_proposals", git: "https://github.com/alecslupu-pfa/decidim-module_homepage_proposals", ref: "992ed0fcfa32e5b86479e706c71eb6523d61de2b" | |||
| gem "decidim-homepage_proposals", git: "https://github.com/alecslupu-pfa/decidim-module_homepage_proposals", ref: "995505d587d87fbc7cccaf94822f5f2285105afb" | |||
There was a problem hiding this comment.
Prefer to use a branch as target rather than a ref
Suggested change
| gem "decidim-homepage_proposals", git: "https://github.com/alecslupu-pfa/decidim-module_homepage_proposals", ref: "995505d587d87fbc7cccaf94822f5f2285105afb" | |
| gem "decidim-homepage_proposals", git: "https://github.com/alecslupu-pfa/decidim-module_homepage_proposals", branch: "<target_branch>" |
Gemfile.lock
Outdated
| @@ -52,8 +52,8 @@ GIT | |||
|
|
|||
| GIT | |||
| remote: https://github.com/alecslupu-pfa/decidim-module_homepage_proposals | |||
| revision: 992ed0fcfa32e5b86479e706c71eb6523d61de2b | |||
| ref: 992ed0fcfa32e5b86479e706c71eb6523d61de2b | |||
| revision: 995505d587d87fbc7cccaf94822f5f2285105afb | |||
There was a problem hiding this comment.
Here you can bump the revision with the target commit hash
Suggested change
| revision: 995505d587d87fbc7cccaf94822f5f2285105afb | |
| revision: 995505d587d87fbc7cccaf94822f5f2285105afb |
|
Thanks for the comments! Changed accordingly on the fix branch. Let me know if anything else is needed. |
Quentinchampenois
approved these changes
Nov 27, 2023
|
LGTM Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a fix here for a major bug - the filters did not update the content inside the carousel. To inspect the bug, check the staging. This should solve it. Merging it with develop will allow us to test it on the staging platform.