Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/missing translation keys #72

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

BarbaraOliveira13
Copy link
Contributor

🎩 Description

Add missing translation keys in files: en.yml & fr.yml for proposals

📌 Related Issues

Link your PR to an issue

Testing

  1. Log as admin
  2. Turn app into French translation
  3. Go to Processes
  4. Select a process
  5. Go to Proposals
  6. Click on Export dropdown
  7. Watch the french translation work

Tasks

  • Add specs
  • Add note about overrides in OVERLOADS.md

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

@BarbaraOliveira13 BarbaraOliveira13 marked this pull request as ready for review April 23, 2024 15:38
Copy link
Contributor

@luciegrau luciegrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@luciegrau luciegrau merged commit 553f9a0 into develop Apr 23, 2024
13 checks passed
@luciegrau luciegrau deleted the fix/missing_translation_keys branch April 23, 2024 15:52
moustachu pushed a commit that referenced this pull request May 24, 2024
* fix: add missing translation keys

* fix: add ruby platform in gemfile.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants