Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] - FranceConnect Logout Modifications #15

Merged
merged 8 commits into from
Mar 17, 2023

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Mar 7, 2023

🎩 Description

Backport of the modifications made on the decidim-app to fix correctly FranceConnect sessions management

Main reason:

  • When we were disconnecting from our platform, our FranceConnect's session was still active and we needed to fix that.

📁 Modifications :

  • Design modifications
    I. Modifications of buttons shared modal
    II. Modifications of the login modal to add FC button
    III. Optimizate displaying of images + text
    IV. Additions of few locales releated to FranceConnect
  • Server-side modifications
    I. Modification of the config of omniauth_france_connect to make it work properly and manually specify the scope
    II. Extend Sessions and Account controllers to disconnect from FranceConnect when disconnecting from the platform
    III. Additions of few tests

🧪 How to test

  • Boot your platform
  • Go to your system page
  • Enable FranceConnect filling in Client ID Client Secret and Site URL and checking enabled
  • Create an account using FranceConnect
  • Connect to this account
  • Disconnect or delete your account
  • Check if you're still connected to FranceConnect

NB : If it works correctly, when you log out you should see a redirect link on your URL before returning to your platform which tells you that you are logged out of your platform.

@AyakorK AyakorK requested review from Quentinchampenois, paulinebessoles and a team March 7, 2023 11:19
@Quentinchampenois Quentinchampenois merged commit 6a6f7d8 into bump/0.26-stable Mar 17, 2023
@Quentinchampenois Quentinchampenois deleted the backport/fix_france_connect branch March 17, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants