fix: private proposal fields (#52)

* feat: Enable opendata download

* feat: Bump awesome and add rake task for migration

* feat: Add private fields rake task command

* lint: Fix rubocop offense

Gemfile.lock

@@ -39,7 +39,7 @@ GIT
 
 GIT
   remote: https://github.com/octree-gva/decidim-module-decidim_awesome.git
-  revision: 21ce064a26837ba43835621ddb6f6773b14c59e8
+  revision: afa824a79faa42f99eee5c0dcb4944e3a78b4a1d
   branch: feat/awesome_decidim_private_fields
   specs:
     decidim-decidim_awesome (0.9.2)

config/routes.rb

@@ -8,8 +8,6 @@
     mount Sidekiq::Web => "/sidekiq"
   end
 
-  get "/open-data/download", to: redirect("/404")
-  post "/open-data/download", to: redirect("/404")
   mount LetterOpenerWeb::Engine, at: "/letter_opener" if Rails.env.development?
 
   mount Decidim::Core::Engine => "/"

db/migrate/20240314092535_create_private_proposal_fields.decidim_decidim_awesome.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+# This migration comes from decidim_decidim_awesome (originally 20230309124413)
+
+class CreatePrivateProposalFields < ActiveRecord::Migration[5.2]
+  def up
+    create_table :decidim_awesome_private_proposal_fields do |t|
+      t.text :private_body, default: "<xml></xml>"
+
+      t.references :proposal, null: false, foreign_key: { to_table: :decidim_proposals_proposals }, index: { name: "decidim_awesome_private_proposal_fields_idx" }
+      t.timestamps
+    end
+  end
+end

lib/tasks/decidim_app.rake

@@ -35,6 +35,7 @@ namespace :decidim_app do
     task install: :environment do
       puts "Running db:migrate"
       Rake::Task["db:migrate"].invoke
+      Rake::Task["decidim:awesome:private_fields"].invoke
     end
 
     # This task is used to upgrade your decidim-app to the latest version
@@ -44,6 +45,7 @@ namespace :decidim_app do
     task upgrade: :environment do
       puts "Running db:migrate"
       Rake::Task["db:migrate"].invoke
+      Rake::Task["decidim:awesome:private_fields"].invoke
     end
 
     desc "usage: bundle exec rails k8s:dump_db"

lib/tasks/repair_data.rake

@@ -51,4 +51,35 @@ namespace :decidim do
       end
     end
   end
+
+  namespace :awesome do
+    desc "Migrate private fields from old proposals to new ones"
+    task private_fields: :environment do
+      Rails.logger.info("Migrating private fields from old proposals to new ones")
+
+      proposals = Decidim::Proposals::Proposal.where(
+        "private_body != ? AND private_body != ?",
+        "<xml></xml>", "{}"
+      ).pluck(:id, :private_body)
+
+      Rails.logger.info("Preparing to migrate #{proposals.count} proposals")
+      creations = proposals.map do |proposal_id, private_body|
+        creation = Decidim::DecidimAwesome::PrivateProposalField.create(
+          proposal_id: proposal_id,
+          private_body: private_body
+        )
+
+        [proposal_id, creation]
+      end
+
+      if creations.any? { |_, creation| creation.invalid? }
+        proposal_ids = creations.select { |ary| ary.last.invalid? }.map(&:first)
+        Rails.logger.error("Failed to migrate #{proposal_ids.count} proposals")
+        Rails.logger.error("Failed proposals ID : #{proposal_ids.join(", ")}")
+        return
+      end
+
+      Rails.logger.info("Migrated #{creations.count} proposals")
+    end
+  end
 end