Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add extra user fields gem #425

Closed
wants to merge 3 commits into from

Conversation

paulinebessoles
Copy link
Contributor

🎩 Description

This PR aims to add the extra user fields gem to the decidim-app 0.27

Testing

Example:

  • Log in as admin
  • Access Backoffice
  • Go to Settings
  • See a dedicated tab for extra user fields

Tasks

  • Add specs
  • Add note about overrides in OVERLOADS.md
  • In case of new dependencies or version bump, update related documentation

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -21.10% ⚠️

Comparison is base (6be0191) 77.06% compared to head (561cc1e) 55.96%.

Additional details and impacted files
@@              Coverage Diff               @@
##           bump_0.27     #425       +/-   ##
==============================================
- Coverage      77.06%   55.96%   -21.10%     
==============================================
  Files             60       54        -6     
  Lines           1574     1517       -57     
==============================================
- Hits            1213      849      -364     
- Misses           361      668      +307     

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armandfardeau
Copy link
Collaborator

Could you rebase or merge #366 ?

@armandfardeau armandfardeau force-pushed the feat/add_extra_user_fields branch from abfb708 to 561cc1e Compare August 31, 2023 09:16
@armandfardeau armandfardeau deleted the feat/add_extra_user_fields branch August 31, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants