Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URL as location when a location isn't provided - develop #65

Open
wants to merge 2 commits into
base: develop-2024-07-01
Choose a base branch
from

Conversation

nickpagz
Copy link
Collaborator

@nickpagz nickpagz commented Mar 8, 2024

Changes proposed in this Pull Request

  • This PR adds an automated work-around to include the virtual event/meeting link or url as the location when a physical location isn't included.
  • The PR also excludes outputting the location field if url and location match.

Testing instructions

  • Add a new test event and include a URL in the "Link" tab, while leaving the "Location" empty.
  • View the event on the front-end.
  • The location field should not be printed.
  • Test adding the event to a Google Calendar, or downloading the other formats.
  • The location field should include the URL.

Mentions #34

@webmink
Copy link
Member

webmink commented Mar 8, 2024

Putting a URL in the Location field of a Google Calendar appointment is not a good idea. Google tries to treat it as an address and attempts to draw a map. The URL is not clickable by recipients and causes frustration. If there is no Location, the URL should be placed in the Description instead.

@nickpagz
Copy link
Collaborator Author

nickpagz commented Mar 8, 2024

@webmink Thanks for the comment. I've tested this in Google calendar on my mac and the app on my iphone, and I don't see this happening. The link remains clickable and it doesn't try to generate a location preview unless I click on the "Preview in Maps" button, though it fails somewhat gracefully with a "No results found". Having said that, I just noticed if adding the event via mobile (iPhone - Safari or Chrome) the url is not included as a location - it's getting stripped out, somewhat aligning with what you're saying. Either way it seems we need to also include it in the description instead for Google Calendar (the other calendar formats seem to already include it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants