Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/804 - addition of thumbnail image to repositories #910

Merged
merged 23 commits into from
Feb 20, 2024

Conversation

D-GopalKrishna
Copy link
Contributor

@D-GopalKrishna D-GopalKrishna commented Feb 19, 2024

Task description:

  • BE for the file upload in the Repositories
  • Update the openapi spec
  • Create a common FE for thumbnail upload - ThumbnailUploadArea - for repo and workspace
  • show different icons in repo based on if thumbnail exists or is - dandi, figshare, or github.
  • A script to update the api definitions and also update the inner openapi.yaml file from api/openapi.yaml.

Short video:

2024-01-17.16-34-37.mp4

@D-GopalKrishna D-GopalKrishna marked this pull request as draft February 19, 2024 08:29
@D-GopalKrishna D-GopalKrishna marked this pull request as ready for review February 19, 2024 10:45
@D-GopalKrishna D-GopalKrishna changed the title Feature/804 new - WIP - addition of thumbnail image to repositories Feature/804 new - addition of thumbnail image to repositories Feb 19, 2024
@D-GopalKrishna D-GopalKrishna changed the title Feature/804 new - addition of thumbnail image to repositories Feature/804 - addition of thumbnail image to repositories Feb 19, 2024
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc filippomc merged commit 56765f0 into develop Feb 20, 2024
2 of 3 checks passed
@filippomc filippomc deleted the feature/804-new branch February 20, 2024 11:17
@D-GopalKrishna
Copy link
Contributor Author

To add the thumbnail column in the osbrepository table. WE alter the table with the following query:
ALTER TABLE osbrepository ADD COLUMN thumbnail VARCHAR(255);

the thumbnail string saved is of the format - repositories/1/thumbnail.bin; so VARCHAR(255) is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants