Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/717 - confirm dialog before deleting the workspace #840

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Feature/717 - confirm dialog before deleting the workspace #840

merged 3 commits into from
Dec 12, 2023

Conversation

D-GopalKrishna
Copy link
Contributor

@D-GopalKrishna D-GopalKrishna commented Dec 7, 2023 •
edited
Loading

Task description:
Adding a confirmation dialog before deleting the workspace.

Two ways to delete -

  1. From the menu in the Workspace Card.
  2. From the Workspace Page. If you delete a workspace there - you get navigated back to Home page.
2023-12-07.17-46-45.mp4

@D-GopalKrishna D-GopalKrishna changed the base branch from master to develop December 7, 2023 13:15
@D-GopalKrishna D-GopalKrishna changed the title Feature/717 Feature/717 - confirm dialog before deleting the workspace Dec 7, 2023
filippomc
filippomc approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc filippomc merged commit 960a096 into develop Dec 12, 2023
3 checks passed
@filippomc filippomc deleted the feature/717 branch December 12, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippomc filippomc filippomc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D-GopalKrishna @filippomc