-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more permanent URL for workspaces page #887
Comments
The latest version on live has broken the old version of the links: |
@pgleeson do you only need /workspace/:workspaceId or also /workspace/open/:workspaceId and /workspace/open/:workspaceId/:app? |
If the other (singular) version works too it would be great, as there may be old deep links. I guess the preferred/default version should be the singular (so https://v2.opensourcebrain.org/workspace/open/1207/nwbexplorer etc is preferred), as it's a single workspace being acted on. |
The plural is the widely accepted option for REST so that paths are consistent with a resource navigation kind of style, so that removing one part of the path still gives working paths, with the idea /workspaces/X is showing the workspace X among all workspaces. A single path just like workspace wouldn't sound as meaningful instead. |
Happy with the plural being the default, as long as both forms still work. Thanks! |
Would be good if https://v2.opensourcebrain.org/workspaces was a valid URL, which shows a view the same as currently on the v2 homepage.
It's possible that the v2 homepage could evolve to be a view of featured workspces and repos... So would be good to get the new URL working and point existing docs, etc. to it.
Note:
https://v2.opensourcebrain.org/repositories/2232
https://v2.opensourcebrain.org/workspace/1207
so https://v2.opensourcebrain.org/workspaces/1207 (i.e. plural) should also point to the identified ws...
The text was updated successfully, but these errors were encountered: