Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc/protobuf build instructions #91

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Doc/protobuf build instructions #91

merged 4 commits into from
Jun 21, 2023

Conversation

thomassedlmayer
Copy link
Contributor

Description

I added the protobuf installation instructions by @pmai (see here) to the build_install_example.adoc. I recently followed these instructions and they worked fine.

Check the checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-sensor-model-packaging.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / Github Actions pass locally with my changes.

@thomassedlmayer thomassedlmayer added the documentation Everything which impacts the quality of the documentation and guidelines. label Nov 4, 2022
@thomassedlmayer thomassedlmayer requested a review from pmai November 4, 2022 15:01
@PhRosenberger
Copy link
Contributor

Where is this PR in relation to already merged #93 here and especially to #715 in OSI? Shouldn't his be aligned and merged, as well?

@pmai pmai self-assigned this Jun 15, 2023
@pmai pmai added this to the 3.6 milestone Jun 15, 2023
@pmai pmai added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Jun 15, 2023
@ThomasNaderBMW ThomasNaderBMW added ReadyToMerge and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Jun 19, 2023
@ThomasNaderBMW
Copy link

CCB Review, 19.06.23:

Can be merged.

@pmai pmai merged commit c6d8d59 into OpenSimulationInterface:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmai pmai pmai approved these changes

Assignees

@pmai pmai

Labels
documentation Everything which impacts the quality of the documentation and guidelines. ReadyToMerge
Projects
None yet
Milestone
V1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@thomassedlmayer @PhRosenberger @ThomasNaderBMW @pmai @jdsika