Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build/master branch renaming #88

Merged
merged 6 commits into from
Dec 12, 2022
Merged

Build/master branch renaming #88

merged 6 commits into from
Dec 12, 2022

Conversation

philipwindecker
Copy link
Contributor

@philipwindecker philipwindecker commented Oct 17, 2022 •
edited
Loading

Reference to a related issue in the repository

Fixes #89

Add a description

See #89

Mention a member

@pmai

Check the checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-sensor-model-packaging.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / Github Actions pass locally with my changes.

@philipwindecker
Changed version naming for master branch
7c10a4a 
Signed-off-by: Philip Windecker <[email protected]>
@philipwindecker
build: Updated ubuntu image
cec4dca 
Signed-off-by: Philip Windecker <[email protected]>
@philipwindecker
Added Antora generator pipeline trigger
c199497 
Signed-off-by: Philip Windecker <[email protected]>
@philipwindecker
Update of pipeline cache action and key to
29ce21e 
force a rebuild of protobuf

Signed-off-by: Philip Windecker <[email protected]>
@philipwindecker
Added additional information to pipeline trigger
3231637 
Signed-off-by: Philip Windecker <[email protected]>
@philipwindecker philipwindecker linked an issue Oct 17, 2022 that may be closed by this pull request
Build: Trigger generator pipeline when source content has changed #89
Closed
@philipwindecker philipwindecker requested a review from pmai October 17, 2022 13:44
@philipwindecker philipwindecker added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Oct 17, 2022
@philipwindecker philipwindecker marked this pull request as ready for review October 17, 2022 13:44
@philipwindecker
Update antora-generator.yml
0a9ddf6 
Only trigger generator if the PR has access to the required secrets.
@philipwindecker
Copy link
Contributor Author

@pmai Suggested changes for Forks have been implemented

pmai
pmai approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge as-is, according to CCB 2022-12-12

@pmai pmai merged commit 591d452 into master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmai pmai pmai approved these changes

Assignees

@pmai pmai

Labels
ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build: Trigger generator pipeline when source content has changed
2 participants
@philipwindecker @pmai