-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change acronym meaning of OSMP #83
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Habedank Clemens <[email protected]>
Signed-off-by: Habedank Clemens <[email protected]>
guid="aabc2174e20f08597cfae6947c96bf86" | ||
variableNamingConvention="structured"> | ||
<CoSimulation | ||
modelIdentifier="OSMPDemoFMU" | ||
canNotUseMemoryManagementFunctions="true"/> | ||
<DefaultExperiment startTime="0.0" stepSize="0.020"/> | ||
<VendorAnnotations> | ||
<Tool name="net.pmsf.osmp" xmlns:osmp="http://xsd.pmsf.net/OSISensorModelPackaging"><osmp:osmp version="1.2.0" osi-version="3.4.0"/></Tool> | ||
<Tool name="net.pmsf.osmp" xmlns:osmp="http://xsd.pmsf.net/OSISimulationModelPackaging"><osmp:osmp version="1.2.0" osi-version="3.4.0"/></Tool> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmai please have a look if the changes in the VendorAnnotations for the example fmus are fine for you (just a result of replace all...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of this can be done in a minor release, since it completely changes the syntax of the standard (different namespace). If we are going to do this, the namespace should be changed to an ASAM-owned domain along the way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is not wrong :)
@engelben would we have a suitable domain at ASAM reserved for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote for a change, as well.
However, things brings me to the more general question of changing OSI to OpenInterface or similar
- to be consistent in ASAM with OpenScenario, OpenDrive, OpenODD, etc.
- to be clearly distinguished from the OSI model, which was the first acronym out there and is confusing conversations all the time..
Signed-off-by: Habedank Clemens <[email protected]>
CCB output 09.05.2022:
|
Signed-off-by: Habedank Clemens [email protected]
For more details see #67