Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change acronym meaning of OSMP #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

clemenshabedank
Copy link
Contributor

Signed-off-by: Habedank Clemens [email protected]

For more details see #67

@clemenshabedank clemenshabedank requested a review from pmai April 6, 2022 07:57
@clemenshabedank clemenshabedank changed the title Change acronym meaning of OSMP WIP: Change acronym meaning of OSMP Apr 6, 2022
Signed-off-by: Habedank Clemens <[email protected]>
guid="aabc2174e20f08597cfae6947c96bf86"
variableNamingConvention="structured">
<CoSimulation
modelIdentifier="OSMPDemoFMU"
canNotUseMemoryManagementFunctions="true"/>
<DefaultExperiment startTime="0.0" stepSize="0.020"/>
<VendorAnnotations>
<Tool name="net.pmsf.osmp" xmlns:osmp="http://xsd.pmsf.net/OSISensorModelPackaging"><osmp:osmp version="1.2.0" osi-version="3.4.0"/></Tool>
<Tool name="net.pmsf.osmp" xmlns:osmp="http://xsd.pmsf.net/OSISimulationModelPackaging"><osmp:osmp version="1.2.0" osi-version="3.4.0"/></Tool>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmai please have a look if the changes in the VendorAnnotations for the example fmus are fine for you (just a result of replace all...).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of this can be done in a minor release, since it completely changes the syntax of the standard (different namespace). If we are going to do this, the namespace should be changed to an ASAM-owned domain along the way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is not wrong :)
@engelben would we have a suitable domain at ASAM reserved for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote for a change, as well.

However, things brings me to the more general question of changing OSI to OpenInterface or similar

  1. to be consistent in ASAM with OpenScenario, OpenDrive, OpenODD, etc.
  2. to be clearly distinguished from the OSI model, which was the first acronym out there and is confusing conversations all the time..

Signed-off-by: Habedank Clemens <[email protected]>
@clemenshabedank clemenshabedank added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Apr 12, 2022
@clemenshabedank clemenshabedank changed the title WIP: Change acronym meaning of OSMP Change acronym meaning of OSMP Apr 12, 2022
@kmeids
Copy link

kmeids commented May 9, 2022

CCB output 09.05.2022:

  1. Name can't be changed in a minor release, however "OSISimulationModelPackaging" can be mentioned in the documentation to indicate that OSMP does not only refer to Sensors but to Simulation in general.

@kmeids kmeids removed the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants