Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FMI 3.0 native support #109

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Add FMI 3.0 native support #109

merged 3 commits into from
Apr 5, 2024

Conversation

pmai
Copy link
Contributor

@pmai pmai commented Mar 26, 2024

Fixes #105

@pmai pmai added this to the V1.5.0 milestone Mar 26, 2024
@pmai pmai self-assigned this Mar 26, 2024
@pmai
Copy link
Contributor Author

pmai commented Mar 26, 2024

@chrbertsch @jakobkaths please take a look if this addresses your needs

@pmai pmai added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Mar 27, 2024
pmai
pmai commented Apr 4, 2024
View reviewed changes
Copy link
Contributor Author

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 2024-04-04: Merge after final fixes as suggested by @fchucholowski.

pmai
pmai commented Apr 4, 2024
View reviewed changes
Copy link
Contributor Author

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustments as per CCB and @fchucholowski feedback,.

doc/spec/basic_conventions.adoc Outdated Show resolved Hide resolved
doc/spec/binary_variables.adoc Outdated Show resolved Hide resolved
@pmai pmai added ReadyToMerge and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Apr 4, 2024
@pmai pmai requested a review from PhRosenberger April 4, 2024 10:38
@pmai pmai merged commit 243a3cb into master Apr 5, 2024
5 checks passed
@pmai pmai deleted the feature/fmi-30-support branch April 5, 2024 14:53
@pmai pmai mentioned this pull request Apr 5, 2024
Closed
@klausschuch
Copy link

klausschuch commented Apr 9, 2024 •
edited
Loading

What is the benefit of the <Annotation> added to the binary variable? Doesn't the mime-type of the binary variable already contain all necessary information?

@pmai
Copy link
Contributor Author

pmai commented Apr 15, 2024

What is the benefit of the added to the binary variable? Doesn't the mime-type of the binary variable already contain all necessary information?

Currently this is mostly redundant, as you note, but this allows uniform handling, and future proofs us when additional information is added to the annotation that is no-longer redundant to FMI 3.0.

But your question prompted me to more directly spell out that the mime type given in the binary variable mimeType attribute and the mime-type attribute in the annotation must match, see #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchucholowski fchucholowski fchucholowski left review comments

@PhRosenberger PhRosenberger PhRosenberger approved these changes

@chrbertsch chrbertsch chrbertsch approved these changes

Assignees

@pmai pmai

Labels
ReadyToMerge
Projects
None yet
Milestone
V1.5.0
Development

Successfully merging this pull request may close these issues.

Update to FMI3.x?
5 participants
@pmai @klausschuch @chrbertsch @PhRosenberger @fchucholowski