Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Traffic Participant Inputs and Outputs #103

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Aug 28, 2023

Add a description

Minor change, exchange 'also' for 'additionally' the clarify, that the mentioned OSI messages can be defined in addition to SensorView and TrafficUpdate. The term 'also' might be misunderstood as 'instead'.

Check the checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-sensor-model-packaging.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / Github Actions pass locally with my changes.

Exchange 'also' for 'additionally' the clarify, that the mentioned OSI messages can be defined in addition to SensorView and TrafficUpdate.
@ClemensLinnhoff ClemensLinnhoff requested review from pmai and jdsika August 28, 2023 12:31
@ClemensLinnhoff ClemensLinnhoff added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Feb 26, 2024
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 2024-02-26: Merge as-is.

@pmai pmai added ReadyToMerge and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Feb 26, 2024
@pmai pmai merged commit 6dc30c2 into master Feb 26, 2024
@pmai pmai deleted the clarify-traffic-participant-description branch February 26, 2024 11:01
@pmai pmai added this to the V1.5.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants