Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and harmonize python installation instructions #800

Merged
merged 1 commit into from
May 6, 2024

Conversation

pmai
Copy link
Contributor

@pmai pmai commented Apr 3, 2024

Adjust python install instructions to be more uniform across platforms and to reflect availability of packages on PyPI.

@pmai pmai added this to the V3.7.0 milestone Apr 3, 2024
@pmai pmai force-pushed the doc/python-setup-update branch from 5ef4910 to ec1882e Compare April 3, 2024 20:05
source venv/bin/activate
----
+
. Install Open Simulation Interface.
.. Local installation
+
----
python3 -m pip install .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you only use it with the prefix: python3 -m pip*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only in specific circumstances (e.g. upgrading pip in place, or where there was a multitude of python installations 2 vs 3 - also somewhat ubuntu specific); on most systems pip install is the suggested way to do stuff, and generally is e.g. the way PyPI recommends it.

Both ways work, but as there already was a mixture between the two, I picked one to stay consistent.

----
+
.. Global installation
+
----
sudo pip3 install .
sudo pip install .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really sudo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't ;), but then I never install globally anyway.

More seriously: That was part of the existing instructions, and yes, if you want the package installed globally then you likely need root permissions on most systems. On Ubuntu e.g. if you do not have root permissions, it will just install for the user.

Not that I would recommend anything like that, hence the local installation is the first suggested one.

@pmai pmai self-assigned this Apr 5, 2024
@pmai pmai added Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Apr 5, 2024
@pmai
Copy link
Contributor Author

pmai commented May 6, 2024

CCB 2024-05-06: Merge as-is.

@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels May 6, 2024
@pmai pmai force-pushed the doc/python-setup-update branch from d45eaf0 to fd93999 Compare May 6, 2024 15:30
@pmai pmai merged commit f479d99 into master May 6, 2024
10 checks passed
@pmai pmai deleted the doc/python-setup-update branch May 6, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants