Feature/proj offset #794
Merged
Feature/proj offset #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomassedlmayer
added
the
Harmonisation
pmai
approved these changes
Mar 22, 2024
thempen
reviewed
Mar 25, 2024
There was a problem hiding this comment.
I Think this proposal is very good. I haven't seen any direct mistakes. As my only remark: I stumbled over the "xOSI" vs the "xWorld" definition. We have many definition of data in world coordinates within the whole OSI standard. Shouldn't they be renamed to xOSI then? Otherwise the formula should be "xWorld = xWorld * cos(yaw) - xWorld * sin(yaw) + xOffset", where xWorld will be with the ProjFramOffset, if one is available. All this naturally applies to the y coordinate as well.
thempen
approved these changes
Mar 25, 2024
thempen
added
the
ReadyForCCBReview
pmai
added
ReadyToMerge
|
CCB 2024-03-25: Merge as-is, handle world coordinate system confusions in separate PR for issue #796. |
Signed-off-by: Thomas Sedlmayer <[email protected]>
Signed-off-by: Thomas Sedlmayer <[email protected]>
Signed-off-by: Thomas Sedlmayer <[email protected]>
Signed-off-by: Thomas Sedlmayer <[email protected]>
Signed-off-by: Pierre R. Mai <[email protected]>
pmai
force-pushed
the
feature/proj_offset
branch
from
417de90 to
274859c
Compare
|
Reviewed for v3.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the PROJ offset mechanism as already defined in OpenDrive. See OpenDrive Specification.