-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system time to sensor data #789
Add system time to sensor data #789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with the proposed rewording to better set expectations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I don't see any downsides in introducing this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only remark I have is that this time could be different in different sensors that are running on the same car, so putting these fields in each DetectionData could provide the flexibility to reflect such scenarios. I mean, when there are multiple lidars witch more than 1 LidarDetectionData, each could have different real world time stamps, right?
Let's further discuss in the meeting :-)
That would be an additional change, if that is wanted; right now the system time is the time of the source of the sensordata, so for a single sensor it is its time, after e.g. sensor fusion it is the system time of the sensor fusion unit, etc. If someone wants to keep track of all of this across, and need to funnel this into OSI rather than measuring at multiple points, and they need something different than the detection time stamps, then another field could be added later on. A lot of ifs though. |
CCB 2024-03-25: Merge as-is after conflicts resolved. |
Signed-off-by: Thomas Sedlmayer <[email protected]>
Signed-off-by: Pierre R. Mai <[email protected]>
f0ae527
to
c050a93
Compare
Reviewed for v3.7.0 |
This PR adds a system/component-specific time to OSI SensorData. This could be used to simulate discrepancies between simulation time frame and component time frame. It could also be used to preserve the component's internal timestamps when using OSI for real sensor measurement data while having the simulation timestamp's zero time set to simulation/trace start (as it is recommended by OSI).
Outcome from WP 19: Real sensor data