-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate various car types in favor of new alias TYPE_CAR #787
Conversation
6180640
to
173e7d7
Compare
The change looks good to me 👍 |
CCB 2024-04-04: Merge as-is. |
This is a result of the harmonization effort across ASAM Open standards Signed-off-by: Pierre R. Mai <[email protected]>
Co-authored-by: jakobkaths <[email protected]> Signed-off-by: Pierre R. Mai <[email protected]>
173e7d7
to
7b38bed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes let the type better align to other standards. It will still be backward compatible and can be used in the new way through the alias functionality. So I do not see a downside. Therefore I approve this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for v3.7.0
This is a first result of the harmonization effort across ASAM Open standards
In preparation of additional types we already deprecate some obvious candidates for removal, namely our plethora of car types.