Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define mandatory field with checker rules #778

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Feb 14, 2024

Reference to a related issue in the repository

#750

Add a description

  • Add is_set to rules.yml
  • Add is_set as rule to OSI fields that shall be mandatory to set
  • Remove "All fields have to be set" from OSI documentation

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

@ClemensLinnhoff ClemensLinnhoff linked an issue Feb 14, 2024 that may be closed by this pull request
ClemensLinnhoff and others added 3 commits February 14, 2024 18:38
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff ClemensLinnhoff added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Feb 26, 2024
@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review February 26, 2024 08:05
@pmai pmai self-assigned this Feb 26, 2024
@pmai
Copy link
Contributor

pmai commented Feb 26, 2024

CCB 2024-02-26: Merge as-is, thanks for the effort.

@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Feb 26, 2024
Copy link
Contributor

@PhRosenberger PhRosenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a starting point. Thanks for adding all of these rules!

@pmai pmai added this to the V3.7.0 milestone Feb 26, 2024
@pmai pmai merged commit 41f14a3 into master Feb 26, 2024
6 checks passed
@pmai pmai deleted the 750-define-mandatory-field-with-checker-rules branch February 26, 2024 10:46
Copy link
Contributor

@jdsika jdsika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define mandatory field with checker rules?
4 participants