Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github actions for release workflow #759

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Update github actions for release workflow #759

merged 2 commits into from
Mar 8, 2024

Conversation

pmai
Copy link
Contributor

@pmai pmai commented Jan 12, 2024

No description provided.

@pmai pmai added the Quality Quality improvements. label Jan 12, 2024
@pmai pmai added this to the V3.7.0 milestone Jan 12, 2024
@pmai pmai requested a review from florianwallerer January 12, 2024 12:43
@pmai pmai self-assigned this Jan 12, 2024
@florianwallerer florianwallerer requested review from florianwallerer and removed request for florianwallerer January 15, 2024 08:16
florianwallerer
florianwallerer approved these changes Jan 15, 2024
View reviewed changes
Copy link

@florianwallerer florianwallerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine :)

@florianwallerer
Copy link

Hi @philipwindecker can you also review this wit a more detailed look and with more knowledge than I have.

@philipwindecker
Copy link
Contributor

Hi @philipwindecker can you also review this wit a more detailed look and with more knowledge than I have.

I can take a look tomorrow. However, I am also quite busy with multiple topics right now, so it might slip to Friday if push comes to shove.

@florianwallerer
Copy link

Hi @philipwindecker can you also review this wit a more detailed look and with more knowledge than I have.

I can take a look tomorrow. However, I am also quite busy with multiple topics right now, so it might slip to Friday if push comes to shove.

Is not time pressing. We have time until the next CCB. Monday 2024-01-29

philipwindecker
philipwindecker approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@philipwindecker philipwindecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work fine in fork. PR approved.

@philipwindecker
Copy link
Contributor

philipwindecker commented Jan 17, 2024 •
edited
Loading

Question @pmai : Do related issues/branches/PRs exist for the other repos? They also use some of these actions and may even run on older version of Ubuntu (image). If so, please link them here in the PR description for reference.

@pmai pmai force-pushed the build/release-action-updates branch from 78e091c to 803c24e Compare March 8, 2024 15:47
@pmai pmai merged commit e47e87c into master Mar 8, 2024
8 checks passed
@pmai pmai deleted the build/release-action-updates branch March 8, 2024 15:49
@pmai pmai added the ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. label Apr 4, 2024
jdsika
jdsika reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@jdsika jdsika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsika jdsika jdsika left review comments

@florianwallerer florianwallerer florianwallerer approved these changes

@philipwindecker philipwindecker philipwindecker approved these changes

Assignees

@pmai pmai

Labels
Quality Quality improvements. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pmai @florianwallerer @philipwindecker @jdsika