-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow: Update Python and Actions + Black formatting Python files #756
Conversation
jdsika
commented
Jan 9, 2024
•
edited
Loading
edited
- Add .venv/ and venv/ to .gitignore
- Bump Python minimum to 3.8 as out of support
- Update GitHub Marketplace Actions
- Add workflow to check black formatting
- Add requirements_develop.txt
- Apply black formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with the code refactoring and black formatting.
I cannot help that much with the workflow changes.
Hope to get some more detailed feedback from @pmai there.
I have created a separate PR for non-python related build workflow changes, that also adds support for newer protobuf releases (upto current 25.x releases), leaving this PR for python-related changes to workflow and python code changes, if wanted. The apt-get update dance should be dropped, since we should never depend on anything more specific from the base system. I'm not a huge fan of the black reformatting (or usually any automatic reformattings), as it just seems to change one set of idiosynchracies for another, but whatever floats anyones boat (I think the code should be rewritten in places to make it clearer, something the reformatting really doesn't address). |
4c85668
to
4f68172
Compare
I've refactored to built upon the other workflow enhancements, so once those are merged only the python-related changes will remain in this PR. |
not that I disagree with your stance towards formatting but in our case this will be done the same way as in the osi-validation and if a lot of people work on something it is helping to provide a consistent visual. |
Signed-off-by: Carlo van Driesten <[email protected]> Signed-off-by: Pierre R. Mai <[email protected]>
Signed-off-by: Pierre R. Mai <[email protected]>
Signed-off-by: Pierre R. Mai <[email protected]>
4f68172
to
493bd51
Compare
CCB 2014-01-15: Merge as-is. |
Reviewed for v3.7.0 |