Feature/issue 416 extend sensor view for microphones #553
Conversation
Signed-off-by: [email protected] Signed-off-by: ITK\abossert <[email protected]>
- message MicrophoneSensorViewConfiguration - repeated MicrophoneViewConfiguration - message MicrophoneSensorView - message MicrophoneSpecificObjectData Signed-off-by: [email protected] Signed-off-by: ITK\abossert <[email protected]>
Signed-off-by: [email protected] Signed-off-by: ITK\abossert <[email protected]>
Signed-off-by: [email protected] Signed-off-by: ITK\abossert <[email protected]>
…f github.com:OpenSimulationInterface/open-simulation-interface into feature/issue-416-Extend_Sensor_View_for_microphones # Conflicts: # osi_detectedobject.proto
osi_featuredata.proto
Outdated
|
|
||
| // Upper bound of frequency range of the microphone sensor. | ||
| // | ||
| // Unit: kHz |
There was a problem hiding this comment.
| // Unit: kHz | |
| // Unit: Hz |
osi_sensorviewconfiguration.proto
Outdated
| optional double field_of_view_horizontal = 4; | ||
|
|
||
| // Field of View in vertical orientation of the physical sensor. | ||
| // | ||
| // Viewing range: [- \c #field_of_view_vertical/2, \c | ||
| // #field_of_view_vertical/2] elevation in the sensor frame at zero azimuth | ||
| // as defined in \c Spherical3d. | ||
| // | ||
| // Unit: rad | ||
| optional double field_of_view_vertical = 5; |
There was a problem hiding this comment.
Is it also vertical and horizontal FoV for Microphones?
There was a problem hiding this comment.
Deleted the vertical field of view
| { | ||
| // Microphone view configuration valid at the time the data was created. | ||
| // | ||
| optional MicrophoneSensorViewConfiguration view_configuration = 1; |
There was a problem hiding this comment.
What would the return data (in a virtual environment) be for a Microphone "sensor"
For example CameraSensroView have "image_data".
There was a problem hiding this comment.
The return data will be the frequency spectrum the microphone has detected.
| // \brief Message encapsulates all data for detected objects that is specific to | ||
| // microphone sensors. | ||
| // | ||
| message MicrophoneSpecificObjectData |
There was a problem hiding this comment.
This should be tailored toward microphones and there usage in AD/ADAS.
There was a problem hiding this comment.
@kmeids I am currently adpating the MicrophoneSpecificObjectData and there I came to a question: What is the meaning of UltrasonicSpecificObjectData::maximum_measurement_distance_sensor? I do not know, if I need something similar in microphone.
kmeids
added
the
SensorModeling
…crophoneSpecificObjectData the distance to the maximum loudness a microphone has detected
|
09.05.2022: @kmeids can you please discuss how to procede in sensor model group regarding proposal etc.. |
Reference to a related issue in the repository
#416
Add a description
Some vehicles are equipped with microphones to detect the sirene of emergency vehicles. Maybe there are more than one microphone to detect the direction. This is not supported from OSI now.
Some questions to ask:
What is this change? Additional sensor: microphone
What does it fix? Missing sensor
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version? extends functionality
How has it been tested? not yet
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!