-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Introduce PedestrianClassification #498
base: master
Are you sure you want to change the base?
Conversation
… in sensorview and sensordata
Does this imply that the |
Good question, we should discuss it. What about defining it in the direction of prior movement? Lower body pose I find a bit problematic, because hard to define and maybe not so meaningful. I think we should also be able to assist usecases that just model the pedestrian as a moving bounding box, which might prefer the direction-of-prior-movement option. What do you think? |
osi_object.proto
Outdated
message PedestrianClassification | ||
{ | ||
// The head pose describes the pedestrian's head orientation. In ground truth / traffic update it is relative to | ||
// the global ground truth frame. In sensordata (detected pedestrians) it is relative to the host vehicle frame. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment Kmeid: Host vehicle frame correct or sensor frame?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmeids the description for detected pedestrians currently is:
Describes the head orientation w.r.t. the host vehicle orientation.
Indeed, I think sensor frame is better (i.e. physical mounting position / mounting position, depending on sensor technology), but after thinking about it I think it is redundant because it is specified in OSI::SensorView. Therefore, I deleted the sentences about coordinate systems in 5089639
Deleting sentences about coordinate systems, since it is redundant information.
OSI CCB:
|
Despite originally planned, I think it is better to plan this for v4.0. Clarification on a pedestrian's bounding box does not seem trivial for different use cases. Merge discussions with #526 going forward. |
@stefancyliax. @clemenshabedank based on #498 (comment) it is meant to be handled in 4.0, is this still the case? |
You are correct. This is supposed to be in 4.0 |
Just so that it won't be lost, here are some brainstorming slides 20210611_ASAM_OSI_Pedestrians.pptx about the pedestrian discussions we had in 06/2021 and before. The discussions were about potential changes going beyond what is in this PR. |
Reference to a related issue in the repository
Discussion in WP11.
Add a description
Added pedestrian classification to have head pose and upper body pose in sensorview and sensordata. So far it exists only in SensorData so that it is unclear where sensor models should get the information from.
Should be currently seen as a discussion point in WP11 -> WIP
Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!